Add support for remote scanning via custom TCP #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
force-pushed
the
feature/enterprise_scanning_squashed
branch
2 times, most recently
from
ca4e694
to
41c27f2
Compare
vtnerd
force-pushed
the
feature/enterprise_scanning_squashed
branch
from
41c27f2
to
8ab23c9
Compare
|
This last force push:
|
|
Finally ran a timed comparison test with 1000 accounts. A Ryzen 3900x saw a 5 minute drop in scan time when two laptops were added to the mix. The laptops took longer, but that is only due to the comparatively slower single threaded CPU performance. The added stress on Looks like this patch will be merged, as it works as expected. I may tweak some of the parameters - most notably the threshold for remote scanning to be initiated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first cut at remote scanning in LWS. It took a while to complete because a custom TCP implementation using ASIO was done - ZMQ sockets were too limited in their capabilities for the task.
There's lots of code here, so I will leave for a bit as I perform additional testing on this, including performance tests. I'm still uncertain on how this will perform with lots of accounts, etc.